mobile: v2 implementation #704

djkazic · 2024-01-15T15:24:26Z

Here's an initial implementation of mobile-v2, which will replace #526. This is distinguished from the initial mobile branch proof of concept by:

Usage of the litd proxy to route requests to subservers
New terminal entrypoint instead of duplicated logic in bindings.go

There needs to be a refactor and some review around this code, so I am opening it as a draft PR.

Note: java protoc code generation was not compiling for loop.proto, seems like the deprecated field id may be causing protoc to create conflicting implementations of getIdBytes() between the new and old id types. Removing the deprecated id fields in SwapResponse and SwapStatus fixes the issue.

dstadulis · 2024-01-15T17:46:11Z

CC @kaloudis

terminal.go

djkazic · 2024-01-15T22:21:23Z

Coming soon: glue code for loop/pool/tapd for proper dialing

kaloudis · 2024-03-04T05:19:11Z

Is there the ability to build the package with select subservices, and not others (eg. build w/ Taproot Assets and Loop, but not Pool)? If so, it's not documented in the README

guggero · 2024-03-04T07:44:35Z

No, not yet. For that we'd need to put a bunch of configuration code behind build flags.

Roasbeef · 2024-03-05T01:41:14Z

@kaloudis have you been able to integrate this PR as is?

kaloudis · 2024-03-16T21:02:46Z

Was having some issues building but with Kevin's help was able to build for Android and iOS. Need to set Docker file sharing implementation to gRPC FUSE if using macOS

related: https://stackoverflow.com/questions/77256594/getting-sed-couldnt-open-temporary-file-permission-denied-error-in-docker-sc

kaloudis · 2024-03-16T21:04:02Z

Next up for the Zeus POC is to find a way to add LNC and Speedloader calls to the exposed methods. Tried to simply replace the LND dependency in the go.mod with replace github.com/lightningnetwork/lnd => github.com/ZeusLN/lnd v0.17.4-beta-zeus.1 but that didn't do the trick.

Will try to pull them into lightning-terminal directly

kaloudis · 2024-03-18T16:47:21Z

Was able to build lightning-terminal mobile with Speedloader and LNC added to it. Working on a POC with Tapas in ZEUS next.

johnanisere · 2024-04-17T00:48:01Z

Hi @djkazic, I'm running this PR in integrated mode on IOS.

When I make requests to tapd, I always get Error: rpc error: code = Unknown desc = invalid macaroon: verification failed: signature mismatch after caveat verification

But requests to Lnd works fine.

this is what my conf file looks like

# Application Options
lnd-mode=integrated
network=testnet
uipassword=password
faraday-mode=remote
loop-mode=remote
pool-mode=remote

# Lnd
lnd.debuglevel=info
lnd.maxbackoff=2s
lnd.nolisten=1
lnd.norest=1


# Lnd - bitcoin
lnd.bitcoin.active=1
lnd.bitcoin.testnet=1
lnd.bitcoin.node=neutrino

# Lnd - Neutrino
lnd.neutrino.addpeer=btcd-testnet.lightning.computer
lnd.neutrino.feeurl=https://nodes.lightning.computer/fees/v1/btc-fee-estimates.json

# Lnd - Autopilot
lnd.autopilot.active=1
lnd.autopilot.private=1
lnd.autopilot.minconfs=1
lnd.autopilot.conftarget=16
lnd.autopilot.allocation=0.5
lnd.autopilot.heuristic=externalscore:0.95
lnd.autopilot.heuristic=preferential:0.05

# Lnd - Routing
lnd.routing.assumechanvalid=1

What could be wrong ?

djkazic · 2024-04-17T02:04:05Z

I've seen that before when using the wrong macaroon.

djkazic · 2024-04-17T02:05:19Z

I can drop the changes needed to fix this in a commit, one sec.

johnanisere · 2024-04-17T12:04:21Z

Hi @djkazic , I can't find the taproot assets api for subscribing to receive events for incoming asset transfers (https://lightning.engineering/api-docs/api/taproot-assets/taproot-assets/subscribe-receive-events) in the IOS framework generated.
I can see the one for subscribing to send events though. Is this intentional?

djkazic · 2024-04-17T12:10:35Z

This is likely a proto file issue. Looking into this now.

djkazic · 2024-04-17T12:13:37Z

Force pushed the latest proto files. Should be working now.

johnanisere · 2024-04-17T12:43:30Z

Thanks @djkazic , now I get these errors when I run make ios

/Users/johnanisere/go/src/github.com/lightninglabs/lightning-terminal/mobile/assetwallet_api_generated.go:190:27: undefined: assetwalletrpc.CommitVirtualPsbtsRequest
/Users/johnanisere/go/src/github.com/lightninglabs/lightning-terminal/mobile/assetwallet_api_generated.go:202:30: undefined: assetwalletrpc.CommitVirtualPsbtsRequest
/Users/johnanisere/go/src/github.com/lightninglabs/lightning-terminal/mobile/assetwallet_api_generated.go:203:18: client.CommitVirtualPsbts undefined (type assetwalletrpc.AssetWalletClient has no field or method CommitVirtualPsbts)
/Users/johnanisere/go/src/github.com/lightninglabs/lightning-terminal/mobile/assetwallet_api_generated.go:219:27: undefined: assetwalletrpc.PublishAndLogRequest
/Users/johnanisere/go/src/github.com/lightninglabs/lightning-terminal/mobile/assetwallet_api_generated.go:231:30: undefined: assetwalletrpc.PublishAndLogRequest
/Users/johnanisere/go/src/github.com/lightninglabs/lightning-terminal/mobile/assetwallet_api_generated.go:232:18: client.PublishAndLogTransfer undefined (type assetwalletrpc.AssetWalletClient has no field or method PublishAndLogTransfer)
/Users/johnanisere/go/src/github.com/lightninglabs/lightning-terminal/mobile/assetwallet_api_generated.go:304:27: undefined: assetwalletrpc.QueryInternalKeyRequest
/Users/johnanisere/go/src/github.com/lightninglabs/lightning-terminal/mobile/assetwallet_api_generated.go:316:30: undefined: assetwalletrpc.QueryInternalKeyRequest
/Users/johnanisere/go/src/github.com/lightninglabs/lightning-terminal/mobile/assetwallet_api_generated.go:317:18: client.QueryInternalKey undefined (type assetwalletrpc.AssetWalletClient has no field or method QueryInternalKey)
/Users/johnanisere/go/src/github.com/lightninglabs/lightning-terminal/mobile/assetwallet_api_generated.go:331:27: undefined: assetwalletrpc.QueryScriptKeyRequest
/Users/johnanisere/go/src/github.com/lightninglabs/lightning-terminal/mobile/assetwallet_api_generated.go:331:27: too many errors
# github.com/lightninglabs/lightning-terminal/mobile
/Users/johnanisere/go/src/github.com/lightninglabs/lightning-terminal/mobile/assetwallet_api_generated.go:190:27: undefined: assetwalletrpc.CommitVirtualPsbtsRequest
/Users/johnanisere/go/src/github.com/lightninglabs/lightning-terminal/mobile/assetwallet_api_generated.go:202:30: undefined: assetwalletrpc.CommitVirtualPsbtsRequest
/Users/johnanisere/go/src/github.com/lightninglabs/lightning-terminal/mobile/assetwallet_api_generated.go:203:18: client.CommitVirtualPsbts undefined (type assetwalletrpc.AssetWalletClient has no field or method CommitVirtualPsbts)
/Users/johnanisere/go/src/github.com/lightninglabs/lightning-terminal/mobile/assetwallet_api_generated.go:219:27: undefined: assetwalletrpc.PublishAndLogRequest
/Users/johnanisere/go/src/github.com/lightninglabs/lightning-terminal/mobile/assetwallet_api_generated.go:231:30: undefined: assetwalletrpc.PublishAndLogRequest
/Users/johnanisere/go/src/github.com/lightninglabs/lightning-terminal/mobile/assetwallet_api_generated.go:232:18: client.PublishAndLogTransfer undefined (type assetwalletrpc.AssetWalletClient has no field or method PublishAndLogTransfer)
/Users/johnanisere/go/src/github.com/lightninglabs/lightning-terminal/mobile/assetwallet_api_generated.go:304:27: undefined: assetwalletrpc.QueryInternalKeyRequest
/Users/johnanisere/go/src/github.com/lightninglabs/lightning-terminal/mobile/assetwallet_api_generated.go:316:30: undefined: assetwalletrpc.QueryInternalKeyRequest
/Users/johnanisere/go/src/github.com/lightninglabs/lightning-terminal/mobile/assetwallet_api_generated.go:317:18: client.QueryInternalKey undefined (type assetwalletrpc.AssetWalletClient has no field or method QueryInternalKey)
/Users/johnanisere/go/src/github.com/lightninglabs/lightning-terminal/mobile/assetwallet_api_generated.go:331:27: undefined: assetwalletrpc.QueryScriptKeyRequest
/Users/johnanisere/go/src/github.com/lightninglabs/lightning-terminal/mobile/assetwallet_api_generated.go:331:27: too many errors
# github.com/lightninglabs/lightning-terminal/mobile
/Users/johnanisere/go/src/github.com/lightninglabs/lightning-terminal/mobile/assetwallet_api_generated.go:190:27: undefined: assetwalletrpc.CommitVirtualPsbtsRequest
/Users/johnanisere/go/src/github.com/lightninglabs/lightning-terminal/mobile/assetwallet_api_generated.go:202:30: undefined: assetwalletrpc.CommitVirtualPsbtsRequest
/Users/johnanisere/go/src/github.com/lightninglabs/lightning-terminal/mobile/assetwallet_api_generated.go:203:18: client.CommitVirtualPsbts undefined (type assetwalletrpc.AssetWalletClient has no field or method CommitVirtualPsbts)
/Users/johnanisere/go/src/github.com/lightninglabs/lightning-terminal/mobile/assetwallet_api_generated.go:219:27: undefined: assetwalletrpc.PublishAndLogRequest
/Users/johnanisere/go/src/github.com/lightninglabs/lightning-terminal/mobile/assetwallet_api_generated.go:231:30: undefined: assetwalletrpc.PublishAndLogRequest
/Users/johnanisere/go/src/github.com/lightninglabs/lightning-terminal/mobile/assetwallet_api_generated.go:232:18: client.PublishAndLogTransfer undefined (type assetwalletrpc.AssetWalletClient has no field or method PublishAndLogTransfer)
/Users/johnanisere/go/src/github.com/lightninglabs/lightning-terminal/mobile/assetwallet_api_generated.go:304:27: undefined: assetwalletrpc.QueryInternalKeyRequest
/Users/johnanisere/go/src/github.com/lightninglabs/lightning-terminal/mobile/assetwallet_api_generated.go:316:30: undefined: assetwalletrpc.QueryInternalKeyRequest
/Users/johnanisere/go/src/github.com/lightninglabs/lightning-terminal/mobile/assetwallet_api_generated.go:317:18: client.QueryInternalKey undefined (type assetwalletrpc.AssetWalletClient has no field or method QueryInternalKey)
/Users/johnanisere/go/src/github.com/lightninglabs/lightning-terminal/mobile/assetwallet_api_generated.go:331:27: undefined: assetwalletrpc.QueryScriptKeyRequest
/Users/johnanisere/go/src/github.com/lightninglabs/lightning-terminal/mobile/assetwallet_api_generated.go:331:27: too many errors
/Users/johnanisere/go/bin/gomobile: ios/arm64: go build -tags mobile,-s,-w,-buildid=,-X,github.com/lightningnetwork/lnd/build.Commit=lightning-terminal-v0.12.2-alpha-23-g447a9fb066c5dfd8380417e96f3c0843d7e45d7e,-X,github.com/lightningnetwork/lnd/build.CommitHash=447a9fb066c5dfd8380417e96f3c0843d7e45d7e,-X,github.com/lightningnetwork/lnd/build.GoVersion=,-X,github.com/lightningnetwork/lnd/build.RawTags=litd,autopilotrpc,signrpc,walletrpc,chainrpc,invoicesrpc,watchtowerrpc,neutrinorpc,peersrpc,-X,github.com/lightninglabs/lightning-terminal.appFilesPrefix=,-X,github.com/lightninglabs/lightning-terminal.Commit=v0.12.2-alpha-23-g447a9fb066c5dfd8380417e96f3c0843d7e45d7e,-X,github.com/lightninglabs/loop.Commit=v0.26.6-beta,-X,github.com/lightninglabs/pool.Commit=v0.6.4-beta.0.20231003174306-80d8854a0c4b,-X,github.com/lightninglabs/taproot-assets.Commit=v0.3.2 -v -buildmode=c-archive -o /var/folders/t5/styjmbqd34q6f9pt1gnk_np00000gn/T/gomobile-work-622384700/Litdmobile-ios-arm64.a ./gobind failed: exit status 1

make: *** [ios] Error 1```

djkazic · 2024-04-17T13:16:30Z

OK so the fundamental issue is that bumping the proto file like that without bumping the dependency is a chicken or egg problem.

@johnanisere we are blocked until taproot-assets cuts a new release. That functionality you described is newer than the latest release (0.3.3). cc @Roasbeef

djkazic · 2024-04-17T13:16:44Z

I'll push a revert of the proto files for now.

djkazic · 2024-04-17T13:20:18Z

OK revert pushed.

johnanisere · 2024-04-17T13:29:41Z

Alright, Got it @djkazic

johnanisere · 2024-04-24T19:10:26Z

Hi @djkazic, I noticed that all requests to Lnd fail until it's fully synced to the chain.
Request to GetInfo also fails, which makes it difficult to calculate sync progress.

djkazic · 2024-04-24T21:25:10Z

I believe that is due to lnd still starting up. Rpc active does not mean it is done. Server active status is needed for rpc requests to be routed.

johnanisere · 2024-05-23T00:35:38Z

Hi @djkazic ,

There seem to be something wrong with tor setup of Litdmobile.
when ever i run Litdmobile with the tor config below, I get this error :
could not load config: ValidateConfig: listening must be enabled when enabling inbound connections over Tor.

Here is what my config file looks like

# Application Options
lnd-mode=integrated
network=testnet
uipassword=password
faraday-mode=remote
loop-mode=remote
pool-mode=remote

# Lnd
lnd.debuglevel=info
lnd.maxbackoff=2s
lnd.nolisten=1
lnd.norest=1


# Lnd - bitcoin
lnd.bitcoin.active=1
lnd.bitcoin.testnet=1
lnd.bitcoin.node=neutrino

# Lnd - Neutrino
lnd.neutrino.addpeer=btcd-testnet.lightning.computer
lnd.neutrino.feeurl=https://nodes.lightning.computer/fees/v1/btc-fee-estimates.json

# Lnd - Autopilot
lnd.autopilot.active=1
lnd.autopilot.private=1
lnd.autopilot.minconfs=1
lnd.autopilot.conftarget=16
lnd.autopilot.allocation=1
lnd.autopilot.heuristic=externalscore:0.95
lnd.autopilot.heuristic=preferential:0.05

# Lnd - Routing
lnd.routing.assumechanvalid=1

# Lnd - Tor
lnd.tor.socks=127.0.0.1:9050
lnd.tor.control=127.0.0.1:9051
lnd.tor.active=1
lnd.tor.v3=1
lnd.tor.password=somepassword
lnd.listen=localhost

What am i doing wrong?

djkazic · 2024-05-23T00:50:16Z

lnd.nolisten=1 is the problem:

https://github.com/lightningnetwork/lnd/blob/4417229bc800752691217c27a7ce615e98c94135/config.go#L1100

johnanisere · 2024-05-23T00:57:33Z

lnd.nolisten=1 is the problem:

https://github.com/lightningnetwork/lnd/blob/4417229bc800752691217c27a7ce615e98c94135/config.go#L1100

oh, thanks @djkazic

lightninglabs-deploy · 2024-11-14T14:15:50Z

@Roasbeef: review reminder
@kaloudis: review reminder
@ViktorTigerstrom: review reminder

lightninglabs-deploy · 2024-11-19T01:52:58Z

Closing due to inactivity

lightninglabs-deploy · 2024-11-19T02:59:22Z

Closing due to inactivity

lightninglabs-deploy · 2024-11-19T04:00:48Z

Closing due to inactivity

lightninglabs-deploy · 2024-11-19T05:04:05Z

Closing due to inactivity

lightninglabs-deploy · 2024-11-19T06:10:21Z

Closing due to inactivity

lightninglabs-deploy · 2024-11-19T07:11:37Z

Closing due to inactivity

lightninglabs-deploy · 2024-11-19T08:19:07Z

Closing due to inactivity

lightninglabs-deploy · 2024-11-19T09:19:28Z

Closing due to inactivity

lightninglabs-deploy · 2024-11-19T10:27:29Z

Closing due to inactivity

lightninglabs-deploy · 2024-11-19T11:28:16Z

Closing due to inactivity

guggero · 2024-11-19T11:31:51Z

!lightninglabs-deploy mute

djkazic requested review from Roasbeef and guggero January 15, 2024 15:24

djkazic force-pushed the mobile-v2 branch from 1c767b1 to 7038045 Compare January 15, 2024 16:37

djkazic force-pushed the mobile-v2 branch from 7038045 to fffeb53 Compare January 15, 2024 18:47

kaloudis reviewed Jan 15, 2024

View reviewed changes

terminal.go Outdated Show resolved Hide resolved

djkazic force-pushed the mobile-v2 branch 3 times, most recently from 85934cd to 361eac3 Compare January 15, 2024 20:29

djkazic changed the title ~~Initial mobilev2 implementation (needs refactor)~~ mobile: v2 implementation Jan 15, 2024

djkazic force-pushed the mobile-v2 branch from 361eac3 to 0424323 Compare January 15, 2024 21:10

djkazic marked this pull request as ready for review January 15, 2024 21:10

djkazic requested a review from kaloudis January 15, 2024 21:11

djkazic force-pushed the mobile-v2 branch 5 times, most recently from fb1770f to 008008a Compare January 16, 2024 15:14

guggero removed their request for review February 13, 2024 15:44

djkazic force-pushed the mobile-v2 branch from 008008a to 6dec6a5 Compare April 17, 2024 02:12

djkazic force-pushed the mobile-v2 branch from 6dec6a5 to 447a9fb Compare April 17, 2024 12:13

Initial mobilev2 implementation

565b05b

djkazic force-pushed the mobile-v2 branch from 447a9fb to 565b05b Compare April 17, 2024 13:20

johnanisere mentioned this pull request Apr 18, 2024

Help with Documentation! djkazic/speedloader#5

Open

dstadulis requested a review from ViktorTigerstrom September 18, 2024 14:41

mobile: v2 implementation #704

Are you sure you want to change the base?

mobile: v2 implementation #704

Conversation

djkazic commented Jan 15, 2024 • edited Loading

dstadulis commented Jan 15, 2024

djkazic commented Jan 15, 2024

kaloudis commented Mar 4, 2024

guggero commented Mar 4, 2024

Roasbeef commented Mar 5, 2024

kaloudis commented Mar 16, 2024

kaloudis commented Mar 16, 2024 • edited Loading

kaloudis commented Mar 18, 2024

johnanisere commented Apr 17, 2024

djkazic commented Apr 17, 2024

djkazic commented Apr 17, 2024

johnanisere commented Apr 17, 2024

djkazic commented Apr 17, 2024

djkazic commented Apr 17, 2024

johnanisere commented Apr 17, 2024

djkazic commented Apr 17, 2024 • edited Loading

djkazic commented Apr 17, 2024

djkazic commented Apr 17, 2024

johnanisere commented Apr 17, 2024

johnanisere commented Apr 24, 2024

djkazic commented Apr 24, 2024

johnanisere commented May 23, 2024 • edited Loading

djkazic commented May 23, 2024

johnanisere commented May 23, 2024

lightninglabs-deploy commented Nov 14, 2024

lightninglabs-deploy commented Nov 19, 2024

lightninglabs-deploy commented Nov 19, 2024

lightninglabs-deploy commented Nov 19, 2024

lightninglabs-deploy commented Nov 19, 2024

lightninglabs-deploy commented Nov 19, 2024

lightninglabs-deploy commented Nov 19, 2024

lightninglabs-deploy commented Nov 19, 2024

lightninglabs-deploy commented Nov 19, 2024

lightninglabs-deploy commented Nov 19, 2024

lightninglabs-deploy commented Nov 19, 2024

guggero commented Nov 19, 2024

djkazic commented Jan 15, 2024 •

edited

Loading

kaloudis commented Mar 16, 2024 •

edited

Loading

djkazic commented Apr 17, 2024 •

edited

Loading

johnanisere commented May 23, 2024 •

edited

Loading